Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15997 )
Change subject: [WIP] IMPALA-2658: Extend the NDV function to accept a precision ...................................................................... Patch Set 11: (16 comments) http://gerrit.cloudera.org:8080/#/c/15997/11/tests/query_test/test_aggregation.py File tests/query_test/test_aggregation.py: http://gerrit.cloudera.org:8080/#/c/15997/11/tests/query_test/test_aggregation.py@87 PS11, Line 87: [2, 9, 96, 988, 980, 1000, 944, 1030, 1020, 990, 1010, 957, 1030, 1027, 9845, 9898], flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/15997/11/tests/query_test/test_aggregation.py@88 PS11, Line 88: [2, 9, 97, 957, 1008, 1016, 1005, 963, 994, 993, 1018, 1004, 963, 1014, 10210, 10280], flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/15997/11/tests/query_test/test_aggregation.py@89 PS11, Line 89: [2, 9, 98, 977, 1024, 1020, 975, 977, 1002, 991, 994, 1006, 977, 999, 10118, 9923], flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/15997/11/tests/query_test/test_aggregation.py@90 PS11, Line 90: [2, 9, 99, 986, 1009, 1011, 994, 980, 997, 994, 1002, 997, 980, 988, 10148, 9987], flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/15997/11/tests/query_test/test_aggregation.py@91 PS11, Line 91: [2, 9, 99, 995, 996, 1000, 998, 988, 995, 999, 997, 999, 988, 979, 9974, 9960], flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/15997/11/tests/query_test/test_aggregation.py@92 PS11, Line 92: [2, 9, 99, 998, 1005, 999, 1003, 994, 1000, 993, 999, 998, 994, 992, 9899, 9941], flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/15997/11/tests/query_test/test_aggregation.py@93 PS11, Line 93: [2, 9, 99, 993, 1001, 1007, 1000, 998, 1002, 997, 999, 998, 998, 999, 9923, 9931], flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/15997/11/tests/query_test/test_aggregation.py@94 PS11, Line 94: [2, 9, 99, 994, 998, 1002, 1002, 999, 998, 999, 997, 1000, 999, 997, 9937, 9973], flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/15997/11/tests/query_test/test_aggregation.py@95 PS11, Line 95: [2, 9, 99, 995, 997, 998, 1001, 999, 1001, 996, 997, 1000, 999, 998, 9989, 9981], flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/15997/11/tests/query_test/test_aggregation.py@96 PS11, Line 96: [2, 9, 99, 998, 998, 997, 999, 998, 1000, 998, 1000, 998, 998, 1000, 10000, 10003] flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/15997/11/tests/query_test/test_aggregation.py@96 PS11, Line 96: flake8: E241 multiple spaces after ',' http://gerrit.cloudera.org:8080/#/c/15997/11/tests/query_test/test_aggregation.py@315 PS11, Line 315: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/15997/11/tests/query_test/test_aggregation.py@315 PS11, Line 315: # Verify that each ndv() value (one per column for a total of 11) is identical line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15997/11/tests/query_test/test_aggregation.py@316 PS11, Line 316: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/15997/11/tests/query_test/test_aggregation.py@316 PS11, Line 316: # to the corresponding known value. Since NDV() invokes Hash64() hash function line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15997/11/tests/query_test/test_aggregation.py@319 PS11, Line 319: - flake8: E226 missing whitespace around arithmetic operator -- To view, visit http://gerrit.cloudera.org:8080/15997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48a4517bd0959f7021143073d37505a46c551a58 Gerrit-Change-Number: 15997 Gerrit-PatchSet: 11 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Fri, 05 Jun 2020 00:30:47 +0000 Gerrit-HasComments: Yes
