Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16019 )
Change subject: IMPALA-9809: A query with multi-aggregation functions on particular dataset crashes impala daemon ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/16019/1/be/src/exec/grouping-aggregator-ir.cc File be/src/exec/grouping-aggregator-ir.cc: http://gerrit.cloudera.org:8080/#/c/16019/1/be/src/exec/grouping-aggregator-ir.cc@160 PS1, Line 160: outBatchStart nit: out_batch_start http://gerrit.cloudera.org:8080/#/c/16019/1/testdata/data/local_parquet_tbl/part-00000-fafc2cd0-f5c8-4fbb-ac3f-717447d67af8-c000.snappy.parquet File testdata/data/local_parquet_tbl/part-00000-fafc2cd0-f5c8-4fbb-ac3f-717447d67af8-c000.snappy.parquet: PS1: Checking in this amount of binary data is an issue for a number of reasons, not least because it bloats the repo checkout... I think it would be best if we checked in the script to generate the data and ran it during data loading. http://gerrit.cloudera.org:8080/#/c/16019/1/tests/query_test/test_aggregation.py File tests/query_test/test_aggregation.py: http://gerrit.cloudera.org:8080/#/c/16019/1/tests/query_test/test_aggregation.py@380 PS1, Line 380: @SkipIfDockerizedCluster.accesses_host_filesystem We should avoid this restriction - other tests achieve similar things without this limitation. We solve this either by copying the files into the cluster with the hdfs client (see the various create_table_and_copy_files() invocations in tests/query_test/test_scanners.py) or by generating and loading the table as part of data loading. -- To view, visit http://gerrit.cloudera.org:8080/16019 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06d73171cdc40bdbb15960573030ac7fc94a7e16 Gerrit-Change-Number: 16019 Gerrit-PatchSet: 1 Gerrit-Owner: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 01 Jun 2020 22:55:53 +0000 Gerrit-HasComments: Yes
