Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16019 )
Change subject: IMPALA-9809: Multi-aggregation query on particular dataset crashes impalad ...................................................................... Patch Set 2: (4 comments) upload the second patch to address review issues. http://gerrit.cloudera.org:8080/#/c/16019/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16019/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-9809: Multi-aggregation query on particular dataset crashes impalad > nit: make the first line more concise so it fits on a single line. Done http://gerrit.cloudera.org:8080/#/c/16019/1/be/src/exec/grouping-aggregator-ir.cc File be/src/exec/grouping-aggregator-ir.cc: http://gerrit.cloudera.org:8080/#/c/16019/1/be/src/exec/grouping-aggregator-ir.cc@160 PS1, Line 160: out_batch_sta > nit: out_batch_start Done http://gerrit.cloudera.org:8080/#/c/16019/1/testdata/data/local_parquet_tbl/part-00000-fafc2cd0-f5c8-4fbb-ac3f-717447d67af8-c000.snappy.parquet File testdata/data/local_parquet_tbl/part-00000-fafc2cd0-f5c8-4fbb-ac3f-717447d67af8-c000.snappy.parquet: PS1: > Checking in this amount of binary data is an issue for a number of reasons, Remove the parquet files. Figure out a query which make tpch.lineitem can reproduce the issue. It saves us a lot of space. http://gerrit.cloudera.org:8080/#/c/16019/1/tests/query_test/test_aggregation.py File tests/query_test/test_aggregation.py: http://gerrit.cloudera.org:8080/#/c/16019/1/tests/query_test/test_aggregation.py@380 PS1, Line 380: def test_min_multiple_distinct(self, vector, unique_database): > We should avoid this restriction - other tests achieve similar things witho removed. Use tpch.lineitem which need not load extra data. -- To view, visit http://gerrit.cloudera.org:8080/16019 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06d73171cdc40bdbb15960573030ac7fc94a7e16 Gerrit-Change-Number: 16019 Gerrit-PatchSet: 2 Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Comment-Date: Tue, 02 Jun 2020 02:30:21 +0000 Gerrit-HasComments: Yes
