Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16019 )
Change subject: IMPALA-9809: Multi-aggregation query on particular dataset crashes impalad ...................................................................... Patch Set 4: (3 comments) Patch 4 addresses review issues. http://gerrit.cloudera.org:8080/#/c/16019/3/testdata/workloads/functional-query/queries/QueryTest/min-multiple-distinct-aggs.test File testdata/workloads/functional-query/queries/QueryTest/min-multiple-distinct-aggs.test: http://gerrit.cloudera.org:8080/#/c/16019/3/testdata/workloads/functional-query/queries/QueryTest/min-multiple-distinct-aggs.test@8 PS3, Line 8: > Can you remove the tpch. prefix? It shouldn't be necessary if this is calle Done http://gerrit.cloudera.org:8080/#/c/16019/3/testdata/workloads/functional-query/queries/QueryTest/min-multiple-distinct-aggs.test@10 PS3, Line 10: > It'd be good to include a results section here to verify that it produces t Done http://gerrit.cloudera.org:8080/#/c/16019/3/tests/query_test/test_aggregation.py File tests/query_test/test_aggregation.py: http://gerrit.cloudera.org:8080/#/c/16019/3/tests/query_test/test_aggregation.py@379 PS3, Line 379: > This fits better in TestTPCAggregationQueries below (l419) Done -- To view, visit http://gerrit.cloudera.org:8080/16019 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06d73171cdc40bdbb15960573030ac7fc94a7e16 Gerrit-Change-Number: 16019 Gerrit-PatchSet: 4 Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Comment-Date: Tue, 02 Jun 2020 18:50:10 +0000 Gerrit-HasComments: Yes
