Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15985 )
Change subject: IMPALA-9778: Refactor partition modifications in DDL/DMLs ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/15985/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15985/10//COMMIT_MSG@13 PS10, Line 13: - Aborted DDL/DMLs won't leave partition metadata in a bad shape, which > Sorry, I found one: IMPALA-8406 Ok great! Do you have a sense for how difficult it would be to add a test for that? I don't want to hold up this change too much, but it's great to have regression tests for failures like this where possible. I think the immutability gives us some confidence that bugs like this shouldn't be possible, but I'd still be concerned about edge cases when we're not exercising those error paths. -- To view, visit http://gerrit.cloudera.org:8080/15985 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib52e5810d01d5e0c910daacb9c98977426d3914c Gerrit-Change-Number: 15985 Gerrit-PatchSet: 10 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Mon, 08 Jun 2020 23:00:15 +0000 Gerrit-HasComments: Yes
