Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15985 )
Change subject: IMPALA-9778: Refactor partition modifications in DDL/DMLs ...................................................................... Patch Set 13: (2 comments) Thanks for the comments! As discussed offline, will rebase this patch once https://gerrit.cloudera.org/c/16008 is merged. http://gerrit.cloudera.org:8080/#/c/15985/10/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/15985/10/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@629 PS10, Line 629: esenta > Does this need to be a immutable data structure as well? Can someone do thi Yes, ideally. Other fields also have this problem. E.g. partitionKeyValues_ is mutable since LiteralExpr is mutable. Actually, making HdfsPartition immutable is a superset for our goal (sharing partitions across different table versions). It requires more refactoring works. I plan to do it in future if needed. I think what we currently need is recreating a HdfsPartition instance for any modifications. This is guared by removing setters and introducing the Builder pattern. http://gerrit.cloudera.org:8080/#/c/15985/12/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/15985/12/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@86 PS12, Line 86: ces instead o > Would be great to document that this class is immutable and we should use H Done -- To view, visit http://gerrit.cloudera.org:8080/15985 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib52e5810d01d5e0c910daacb9c98977426d3914c Gerrit-Change-Number: 15985 Gerrit-PatchSet: 13 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Thu, 11 Jun 2020 07:34:59 +0000 Gerrit-HasComments: Yes
