Vihang Karajgaonkar has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/16030 )
Change subject: IMPALA-9824: MetastoreClientPool should be singleton ...................................................................... IMPALA-9824: MetastoreClientPool should be singleton This patch is a refactor-only patch. It changes the MetastoreClientPool into process wide singleton object. Currently, it is possible to instantiate multiple MetastoreClientPools although it doesn't seem to be a problem since all the places which instantiate it happen to run in separate processes. It would be better to enforce this in code. Making MetastoreClientPool a singleton also makes it easier to access from anywhere in the code without the need to explicitly pass its reference around which complicates the code flow unnecessarily. Additionally, this patch also introduces two new configurations coordinator_initial_hms_connections and catalog_initial_hms_connections which define the initial number of HMS clients which are created for the respective services. The default values of both the configurations are kept same as previous values from the code. Testing: 1. No new tests were added since this was mostly a refactor-only patch. 2. Ran existing core tests. Change-Id: I5477cba68b9053dfae8e7ed785f4d7519c12cd0f --- M be/src/catalog/catalog.cc M be/src/catalog/catalogd-main.cc M be/src/service/frontend.cc M be/src/util/backend-gflag-util.cc M common/thrift/BackendGflags.thrift M fe/src/main/java/org/apache/impala/catalog/Catalog.java M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java R fe/src/main/java/org/apache/impala/catalog/EmbeddedMetastoreClientPool.java M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java M fe/src/main/java/org/apache/impala/catalog/MetaStoreClientPool.java M fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java M fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/main/java/org/apache/impala/service/JniCatalog.java M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java M fe/src/test/java/org/apache/impala/common/AbstractFrontendTest.java M fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java A fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestTransientCatalog.java M fe/src/test/java/org/apache/impala/testutil/PlannerTestCaseLoader.java 19 files changed, 250 insertions(+), 132 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/16030/5 -- To view, visit http://gerrit.cloudera.org:8080/16030 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5477cba68b9053dfae8e7ed785f4d7519c12cd0f Gerrit-Change-Number: 16030 Gerrit-PatchSet: 5 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
