Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16030 )
Change subject: IMPALA-9824: MetastoreClientPool should be singleton ...................................................................... Patch Set 5: When ran the tests I realized that TestCaseLoaderTest fails when we run it along with other FE tests. The tests works if we run it alone. This issue is that during our tests we execute multiple mvn tests in the same JVM and hence the expectation that there must be one metastorePool per process fails. I think there is no good way to solve these two conflicting goals. I believe that metastore pool being tightly coupled with each instance of Catalog is a better model since that way we can have multiple Catalogs in the same processes (for testing or otherwise). Any thoughts Quanlong? -- To view, visit http://gerrit.cloudera.org:8080/16030 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5477cba68b9053dfae8e7ed785f4d7519c12cd0f Gerrit-Change-Number: 16030 Gerrit-PatchSet: 5 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Thu, 11 Jun 2020 23:58:53 +0000 Gerrit-HasComments: No
