Daniel Becker has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16059 )
Change subject: IMPALA-9747: More fine-grained codegen for text file scanners ...................................................................... IMPALA-9747: More fine-grained codegen for text file scanners Currently if the materialization of any column cannot be codegen'd because its type is unsupported (e.g. CHAR(N)), the whole codegen is cancelled for the text scanner. This commit adds the function TextConverter::SupportsCodegenWriteSlot that returns whether the given ColumnType is supported. If the type is not supported, HdfsScanner codegens code that calls the interpreted version instead of failing codegen. For other columns codegen is used as usually. Benchmarks: TODO Testing: TODO Change-Id: Id370193af578ecf23ed3c6bfcc65fec448156fa3 --- M be/src/codegen/gen_ir_descriptions.py M be/src/exec/hdfs-scanner-ir.cc M be/src/exec/hdfs-scanner.cc M be/src/exec/hdfs-scanner.h M be/src/exec/text-converter.cc M be/src/exec/text-converter.h 6 files changed, 71 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/16059/4 -- To view, visit http://gerrit.cloudera.org:8080/16059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id370193af578ecf23ed3c6bfcc65fec448156fa3 Gerrit-Change-Number: 16059 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
