Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16059 )
Change subject: IMPALA-9747: More fine-grained codegen for text file scanners ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/16059/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16059/3//COMMIT_MSG@16 PS3, Line 16: version instead of failing codegen. For other columns codegen is used as > Do you think it is tested in a unit test or an integration test? I think that it is tested in https://github.com/apache/impala/blob/0167c5b4242fcebf6be19aba5ecfb440204278ad/testdata/workloads/functional-query/queries/QueryTest/chars.test, but it may make sense to add a few tests (e.g using functional.chars_medium) that read both both char(N) and other types of columns. A test that reads only char(N) (so that non of the columns' writeSlot can be codegend) could be also useful. -- To view, visit http://gerrit.cloudera.org:8080/16059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id370193af578ecf23ed3c6bfcc65fec448156fa3 Gerrit-Change-Number: 16059 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 11 Jun 2020 13:16:12 +0000 Gerrit-HasComments: Yes
