Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15997 )
Change subject: IMPALA-2658: Extend the NDV function to accept a precision ...................................................................... Patch Set 28: (3 comments) http://gerrit.cloudera.org:8080/#/c/15997/28/tests/query_test/test_aggregation.py File tests/query_test/test_aggregation.py: http://gerrit.cloudera.org:8080/#/c/15997/28/tests/query_test/test_aggregation.py@281 PS28, Line 281: p flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/15997/28/tests/query_test/test_aggregation.py@281 PS28, Line 281: """ Test two argument version of NDV() against different column data types. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15997/28/tests/query_test/test_aggregation.py@286 PS28, Line 286: ] flake8: E501 line too long (92 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/15997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48a4517bd0959f7021143073d37505a46c551a58 Gerrit-Change-Number: 15997 Gerrit-PatchSet: 28 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Sat, 13 Jun 2020 03:45:27 +0000 Gerrit-HasComments: Yes
