Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15997 )
Change subject: IMPALA-2658: Extend the NDV function to accept a precision ...................................................................... Patch Set 29: (2 comments) http://gerrit.cloudera.org:8080/#/c/15997/29/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/15997/29/be/src/exprs/aggregate-functions-ir.cc@1483 PS29, Line 1483: void AggregateFunctions::HllUpdateImp(FunctionContext* ctx, const T& src, StringVal* dst, int precision) { line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/15997/29/be/src/exprs/aggregate-functions-ir.cc@2530 PS29, Line 2530: // NDV() is computed with a precision indirectly specified through line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/15997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48a4517bd0959f7021143073d37505a46c551a58 Gerrit-Change-Number: 15997 Gerrit-PatchSet: 29 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Sat, 13 Jun 2020 16:02:58 +0000 Gerrit-HasComments: Yes
