Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16092 )
Change subject: IMPALA-9866: Query plan debug page stuck in fetch and render loop. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16092/1/www/query_plan.tmpl File www/query_plan.tmpl: http://gerrit.cloudera.org:8080/#/c/16092/1/www/query_plan.tmpl@140 PS1, Line 140: var summary = json["summary"]; Not sure about this bit. Isn't this set once the query starts running, not when it finishes? Is the intent that users should manually refresh once they've got the first graph? Maybe this is ok, but didn't match the description in the commit message. http://gerrit.cloudera.org:8080/#/c/16092/1/www/query_plan.tmpl@229 PS1, Line 229: var intervalId = setInterval(refresh, 1000); Probably refreshing every 1s is overkill anyway, since the status report interval is 5s (i.e. data may be up to 5s out of date regardless). -- To view, visit http://gerrit.cloudera.org:8080/16092 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1f233c90d5f221813833af2e29be2250936d442 Gerrit-Change-Number: 16092 Gerrit-PatchSet: 1 Gerrit-Owner: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 18 Jun 2020 18:16:03 +0000 Gerrit-HasComments: Yes
