Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16092 )
Change subject: IMPALA-9866: Query plan debug page stuck in fetch and render loop. ...................................................................... Patch Set 1: (2 comments) Added a field to indicate query completion. http://gerrit.cloudera.org:8080/#/c/16092/1/www/query_plan.tmpl File www/query_plan.tmpl: http://gerrit.cloudera.org:8080/#/c/16092/1/www/query_plan.tmpl@140 PS1, Line 140: var summary = json["summary"]; > Not sure about this bit. Isn't this set once the query starts running, not Yes in my testing I was using summary being filled to detect query completion, turns it the timing of fetching the response made it seem like this was a good indicator, but the summary is always. Instead added an attribute to the json response to indicate if the query was still in flight. http://gerrit.cloudera.org:8080/#/c/16092/1/www/query_plan.tmpl@229 PS1, Line 229: var intervalId = setInterval(refresh, 1000); > Probably refreshing every 1s is overkill anyway, since the status report in I upped it to 2s only because higher values made the animation of the plan metrics and color flow very choppy. -- To view, visit http://gerrit.cloudera.org:8080/16092 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1f233c90d5f221813833af2e29be2250936d442 Gerrit-Change-Number: 16092 Gerrit-PatchSet: 1 Gerrit-Owner: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 19 Jun 2020 21:59:44 +0000 Gerrit-HasComments: Yes
