Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14735 )
Change subject: POC: Remote codegen (Milestone 1) ...................................................................... Patch Set 4: (12 comments) http://gerrit.cloudera.org:8080/#/c/14735/4/testdata/bin/server.py File testdata/bin/server.py: http://gerrit.cloudera.org:8080/#/c/14735/4/testdata/bin/server.py@12 PS4, Line 12: def save_log_file(contents): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/14735/4/testdata/bin/server.py@17 PS4, Line 17: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/14735/4/testdata/bin/server.py@23 PS4, Line 23: def bc_to_ll(bc): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/14735/4/testdata/bin/server.py@41 PS4, Line 41: def has_non64bit_reloc(obj_file): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/14735/4/testdata/bin/server.py@67 PS4, Line 67: def compile_program(data): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/14735/4/testdata/bin/server.py@79 PS4, Line 79: [ flake8: E126 continuation line over-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/14735/4/testdata/bin/server.py@106 PS4, Line 106: def to_message(data): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/14735/4/testdata/bin/server.py@111 PS4, Line 111: class MyTCPHandler(SocketServer.BaseRequestHandler): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/14735/4/testdata/bin/server.py@157 PS4, Line 157: class Server(SocketServer.ForkingMixIn, SocketServer.TCPServer): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/14735/4/testdata/bin/server.py@160 PS4, Line 160: def server_main(): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/14735/4/testdata/bin/server.py@171 PS4, Line 171: def client_main(): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/14735/4/testdata/bin/server.py@181 PS4, Line 181: if __name__ == "__main__": flake8: E305 expected 2 blank lines after class or function definition, found 1 -- To view, visit http://gerrit.cloudera.org:8080/14735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I375d969ceb31b3ee234d6ca56a77d508ae43bb0f Gerrit-Change-Number: 14735 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 22 Jun 2020 10:54:52 +0000 Gerrit-HasComments: Yes
