Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14735 )
Change subject: POC: Remote codegen (Milestone 1) ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/14735/5/be/src/codegen/llvm-codegen.h File be/src/codegen/llvm-codegen.h: http://gerrit.cloudera.org:8080/#/c/14735/5/be/src/codegen/llvm-codegen.h@346 PS5, Line 346: /// If 'async' is true, start executing 'FinalizeModule' in a separate thread and return. line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/14735/5/be/src/service/fe-support.cc File be/src/service/fe-support.cc: http://gerrit.cloudera.org:8080/#/c/14735/5/be/src/service/fe-support.cc@242 PS5, Line 242: status = codegen->FinalizeModule(false, false, nullptr); /// TODO: Check whether the arguments are ok. line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/14735/5/testdata/bin/server.py File testdata/bin/server.py: http://gerrit.cloudera.org:8080/#/c/14735/5/testdata/bin/server.py@207 PS5, Line 207: if __name__ == "__main__": flake8: E305 expected 2 blank lines after class or function definition, found 1 -- To view, visit http://gerrit.cloudera.org:8080/14735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I375d969ceb31b3ee234d6ca56a77d508ae43bb0f Gerrit-Change-Number: 14735 Gerrit-PatchSet: 5 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 07 Jul 2020 13:56:18 +0000 Gerrit-HasComments: Yes
