Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/16091 )
Change subject: IMPALA-9697: Support priority based scratch directory selection ...................................................................... Patch Set 2: (11 comments) http://gerrit.cloudera.org:8080/#/c/16091/1/be/src/runtime/tmp-file-mgr.h File be/src/runtime/tmp-file-mgr.h: http://gerrit.cloudera.org:8080/#/c/16091/1/be/src/runtime/tmp-file-mgr.h@103 PS1, Line 103: TmpDir(const std::string& path, int64_t bytes_limit, int priority, > line too long (99 > 90) Done http://gerrit.cloudera.org:8080/#/c/16091/1/be/src/runtime/tmp-file-mgr.h@104 PS1, Line 104: IntGauge* bytes_used_metric) > line too long (105 > 90) Done http://gerrit.cloudera.org:8080/#/c/16091/1/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/16091/1/be/src/runtime/tmp-file-mgr.cc@194 PS1, Line 194: LOG(ERROR) << "Malformed scratch directory capacity configuration '" > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/16091/1/be/src/runtime/tmp-file-mgr.cc@207 PS1, Line 207: LOG(ERROR) << "Malformed scratch directory priority configuration '" > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/16091/1/be/src/runtime/tmp-file-mgr.cc@259 PS1, Line 259: tmp_dirs_.emplace_back(scratch_subdir_path.string(), tmp_dirs[i]->bytes_limit, > tab used for whitespace Done http://gerrit.cloudera.org:8080/#/c/16091/1/tests/custom_cluster/test_scratch_disk.py File tests/custom_cluster/test_scratch_disk.py: http://gerrit.cloudera.org:8080/#/c/16091/1/tests/custom_cluster/test_scratch_disk.py@20 PS1, Line 20: import os > flake8: F401 'copy' imported but unused Done http://gerrit.cloudera.org:8080/#/c/16091/1/tests/custom_cluster/test_scratch_disk.py@230 PS1, Line 230: , > flake8: E231 missing whitespace after ',' Done http://gerrit.cloudera.org:8080/#/c/16091/1/tests/custom_cluster/test_scratch_disk.py@231 PS1, Line 231: , > flake8: E231 missing whitespace after ',' Done http://gerrit.cloudera.org:8080/#/c/16091/1/tests/custom_cluster/test_scratch_disk.py@232 PS1, Line 232: , > flake8: E231 missing whitespace after ',' Done http://gerrit.cloudera.org:8080/#/c/16091/1/tests/custom_cluster/test_scratch_disk.py@233 PS1, Line 233: , > flake8: E231 missing whitespace after ',' Done http://gerrit.cloudera.org:8080/#/c/16091/1/tests/custom_cluster/test_scratch_disk.py@234 PS1, Line 234: > flake8: E231 missing whitespace after ',' Done -- To view, visit http://gerrit.cloudera.org:8080/16091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I381c3a358e1382e6696325fec74667f1fa18dd17 Gerrit-Change-Number: 16091 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 22 Jun 2020 15:50:42 +0000 Gerrit-HasComments: Yes
