Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16091 )
Change subject: IMPALA-9697: Support priority based scratch directory selection ...................................................................... Patch Set 2: (4 comments) I think this basically looks good, thanks for adding all the tests. http://gerrit.cloudera.org:8080/#/c/16091/2/be/src/runtime/tmp-file-mgr-test.cc File be/src/runtime/tmp-file-mgr-test.cc: http://gerrit.cloudera.org:8080/#/c/16091/2/be/src/runtime/tmp-file-mgr-test.cc@1126 PS2, Line 1126: const int alloc_size = 1024; Comment that each scratch directory can fit exactly one allocation? http://gerrit.cloudera.org:8080/#/c/16091/2/be/src/runtime/tmp-file-mgr.h File be/src/runtime/tmp-file-mgr.h: http://gerrit.cloudera.org:8080/#/c/16091/2/be/src/runtime/tmp-file-mgr.h@116 PS2, Line 116: int const priority; nit: const int. Should be const int64_t for bytes_limit too. 'git blame' shows that I'm responsible for bytes_limit, but no idea why I wrote it that way. http://gerrit.cloudera.org:8080/#/c/16091/2/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/16091/2/be/src/runtime/tmp-file-mgr.cc@216 PS2, Line 216: tmp_dirs.emplace_back(std::move(tmp_dir)); Why not just directly emplace_back, i.e. tmp_dirs.emplace_back(new TmpDir(...)); http://gerrit.cloudera.org:8080/#/c/16091/2/be/src/runtime/tmp-file-mgr.cc@540 PS2, Line 540: << "Invalid index range"; Maybe print the values in the DCHECK error -- To view, visit http://gerrit.cloudera.org:8080/16091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I381c3a358e1382e6696325fec74667f1fa18dd17 Gerrit-Change-Number: 16091 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 24 Jun 2020 23:37:27 +0000 Gerrit-HasComments: Yes
