Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16099 )
Change subject: IMPALA-9878: Fix use-after-free in TmpFileMgrTest's TestAllocation ...................................................................... IMPALA-9878: Fix use-after-free in TmpFileMgrTest's TestAllocation ASAN found a use-after-free for the in this code: file_group.Close(); <--- free underlying storage for 'file' EXPECT_FALSE(boost::filesystem::exists(file->path())); <-- use 'file' This switches it to a copy of file->path(). Testing: - Ran tmp-file-mgr-test under ASAN Change-Id: Idd5cbae70c287c78db8d1c560d8c777d6bed5b56 Reviewed-on: http://gerrit.cloudera.org:8080/16099 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/runtime/tmp-file-mgr-test.cc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/16099 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Idd5cbae70c287c78db8d1c560d8c777d6bed5b56 Gerrit-Change-Number: 16099 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
