Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 )
Change subject: IMPALA-5444: Asynchronous code generation ...................................................................... Patch Set 41: (2 comments) http://gerrit.cloudera.org:8080/#/c/15105/41/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/15105/41/be/src/codegen/llvm-codegen.cc@1171 PS41, Line 1171: SCOPED_TIMER(compile_thread_timer_); I realised that we're not including the codegen time in TotalCpuTime on the profile. Before this change it was done on a fragment instance thread, so was indirectly included. I think we should add a thread timer for this thread, and figure out how to include it in the user and system time in QueryState::ConstructReport() - I think we probably need to pull them out of the host profile? http://gerrit.cloudera.org:8080/#/c/15105/41/be/src/runtime/fragment-state.cc File be/src/runtime/fragment-state.cc: http://gerrit.cloudera.org:8080/#/c/15105/41/be/src/runtime/fragment-state.cc@110 PS41, Line 110: SCOPED_THREAD_COUNTER_MEASUREMENT(codegen()->llvm_thread_counters()); I think there's a pre-existing bug here where we are not including the optimisation time in these thread counters (which we should). -- To view, visit http://gerrit.cloudera.org:8080/15105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7cbfa7c6734dcf03641629429057d6a4194aa6b Gerrit-Change-Number: 15105 Gerrit-PatchSet: 41 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 24 Jun 2020 23:16:55 +0000 Gerrit-HasComments: Yes
