Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 )
Change subject: IMPALA-5444: Asynchronous code generation ...................................................................... Patch Set 43: Code-Review+1 (1 comment) I can upgrade to a +2 if needed. I know Csaba and Zoltan were involved early on in reviewing this so want to give them a chance to take a final look. http://gerrit.cloudera.org:8080/#/c/15105/41/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/15105/41/be/src/codegen/llvm-codegen.cc@1171 PS41, Line 1171: Status thread_start_status = Thread::Create("async-codegen", "async-codegen", > Do you think it affects the results of the single node benchmarks on the ba This wouldn't affect the single-node benchmarks. Those measure the client query latency so are agnostic about what's happening inside the box, or what's in the profile. The total CPU time is useful for profile analysis, e.g. attributing CPU usage to queries, users, etc. -- To view, visit http://gerrit.cloudera.org:8080/15105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7cbfa7c6734dcf03641629429057d6a4194aa6b Gerrit-Change-Number: 15105 Gerrit-PatchSet: 43 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 29 Jun 2020 18:37:44 +0000 Gerrit-HasComments: Yes
