Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16096 )
Change subject: IMPALA-9569: Show progress bar and live_summary of the retried query ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/16096/5/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/16096/5/be/src/service/impala-server.cc@759 PS5, Line 759: if (query_handle->IsRetriedQuery()) result->__set_error_logs(error_logs); is there a specific reason to set the error logs at the end of the method rather than inside the above if statement that adds the entries to error_logs? i guess one benefit is that if the Coordinator is null, then the error logs can still be exposed? might be good to add a code comment mentioning this because its not immediately obvious give that this if statement condition is the same as the above if statement condition http://gerrit.cloudera.org:8080/#/c/16096/5/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/16096/5/shell/impala_shell.py@1100 PS5, Line 1100: if query_id_search and len(query_id_search.groups()) >= 1: the length of the group should only be 1, right? -- To view, visit http://gerrit.cloudera.org:8080/16096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f96919f00e0b64d589efd15b6b5ec82fb725d56 Gerrit-Change-Number: 16096 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Sat, 27 Jun 2020 02:21:33 +0000 Gerrit-HasComments: Yes
