Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16096 )
Change subject: IMPALA-9569: Fix progress bar and live_summary to show info of the retried query ...................................................................... IMPALA-9569: Fix progress bar and live_summary to show info of the retried query Impala-shell periodically calls GetExecSummary() when the query is queuing or running. If the query is being retried, GetExecSummary() should return the TExecSummary of the retried query. So the progress bar and live_summary can reflect the most recent state. This patch also modifies get_summary() to return retry information in error_logs of TExecSummary. Impala-shell and other clients can print the info right after the query starts being retried. Modified impala-shell to print the retried query link when the retried query is running. Example output when the retried query is running: Query: select count(*) from functional.alltypes where bool_col = sleep(60) Query submitted at: 2020-06-18 22:08:49 (Coordinator: http://quanlong-OptiPlex-BJ:25000) Query progress can be monitored at: http://quanlong-OptiPlex-BJ:25000/query_plan?query_id=9444fe7f0df0da28:29134b0800000000 Failed due to unreachable impalad(s): quanlong-OptiPlex-BJ:22001 Retrying query using query id: 5748d9a3ccc28ba8:a75e2fab00000000 Retried query link: http://quanlong-OptiPlex-BJ:25000/query_plan?query_id=5748d9a3ccc28ba8:a75e2fab00000000 [############################### ] 50% Tests: - Manually verify the progress bar and live_summary work when the query is being retried. - Add tests in test_query_retries.py to validate the get_summary() results. Change-Id: I8f96919f00e0b64d589efd15b6b5ec82fb725d56 Reviewed-on: http://gerrit.cloudera.org:8080/16096 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/service/impala-server.cc M be/src/service/impala-server.h M shell/impala_shell.py M tests/common/impala_connection.py M tests/custom_cluster/test_query_retries.py 5 files changed, 120 insertions(+), 28 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8f96919f00e0b64d589efd15b6b5ec82fb725d56 Gerrit-Change-Number: 16096 Gerrit-PatchSet: 8 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
