Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 )
Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. ...................................................................... Patch Set 14: Code-Review+1 (8 comments) http://gerrit.cloudera.org:8080/#/c/15963/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15963/14//COMMIT_MSG@10 PS14, Line 10: batches added to current unsorted run or memory limit is hit, sorter missing 'are'? http://gerrit.cloudera.org:8080/#/c/15963/14//COMMIT_MSG@11 PS14, Line 11: will immediately start the run. If the latter case happen, sorter will nit: happens http://gerrit.cloudera.org:8080/#/c/15963/14//COMMIT_MSG@13 PS14, Line 13: run object, and continue add the next row batches, and so on. missing 'to' http://gerrit.cloudera.org:8080/#/c/15963/14//COMMIT_MSG@15 PS14, Line 15: try nit: tries http://gerrit.cloudera.org:8080/#/c/15963/14//COMMIT_MSG@23 PS14, Line 23: speedup nit: speeds up http://gerrit.cloudera.org:8080/#/c/15963/14//COMMIT_MSG@26 PS14, Line 26: exceed nit: exceeded http://gerrit.cloudera.org:8080/#/c/15963/14//COMMIT_MSG@32 PS14, Line 32: fitted nit: fit http://gerrit.cloudera.org:8080/#/c/15963/14/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: http://gerrit.cloudera.org:8080/#/c/15963/14/be/src/runtime/sorter.cc@952 PS14, Line 952: 2 I didn't catch this one - I think that it should be also VLOG(3) -- To view, visit http://gerrit.cloudera.org:8080/15963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a0ba7c4bae4f1d300d4d9d7f594f63ced06a240 Gerrit-Change-Number: 15963 Gerrit-PatchSet: 14 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 30 Jun 2020 08:19:11 +0000 Gerrit-HasComments: Yes
