Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16152 )
Change subject: IMPALA-9924: handle single subquery in or predicate ...................................................................... Patch Set 10: (1 comment) > Patch Set 8: > > (3 comments) http://gerrit.cloudera.org:8080/#/c/16152/8/testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test File testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test: http://gerrit.cloudera.org:8080/#/c/16152/8/testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test@3730 PS8, Line 3730: | other predicates: int_col % 2 = 0 OR min(id) IS NOT NULL > Oh I see what you're saying - we only actually need to check if min(id) is Updated OR predicate LGTM. -- To view, visit http://gerrit.cloudera.org:8080/16152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64588992901afd7cd885419a0b7f949b0b174976 Gerrit-Change-Number: 16152 Gerrit-PatchSet: 10 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 10 Jul 2020 06:13:58 +0000 Gerrit-HasComments: Yes
