Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16152 )
Change subject: IMPALA-9924: handle single subquery in or predicate ...................................................................... Patch Set 10: Code-Review+2 (2 comments) I went over the code and it LGTM. Since Aman and Shant already gave it +1, I'm giving it +2. http://gerrit.cloudera.org:8080/#/c/16152/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16152/10//COMMIT_MSG@12 PS10, Line 12: The approach used is to rewrite the subquery into : a many-to-one LEFT OUTER JOIN with the subquery and : then replace the subquery in the expression with a : reference to the single select list expressions of : the subquery. nit: Could you provide an example, like this query is rewritten to this query/plan? Maybe just copy a simple case from the planner tests. http://gerrit.cloudera.org:8080/#/c/16152/10/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java: http://gerrit.cloudera.org:8080/#/c/16152/10/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@388 PS10, Line 388: nit: extra spaces -- To view, visit http://gerrit.cloudera.org:8080/16152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64588992901afd7cd885419a0b7f949b0b174976 Gerrit-Change-Number: 16152 Gerrit-PatchSet: 10 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 10 Jul 2020 11:56:27 +0000 Gerrit-HasComments: Yes
