Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16152 )
Change subject: IMPALA-9924: handle single subquery in or predicate ...................................................................... Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/16152/12/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java: http://gerrit.cloudera.org:8080/#/c/16152/12/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@312 PS12, Line 312: boolean isDisjunctive = hasSubqueryInDisjunction(expr); > The previous check here was too narrow - there are some cases where the dis Ack http://gerrit.cloudera.org:8080/#/c/16152/12/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@617 PS12, Line 617: } else if (!(parent instanceof Predicate)) { > There were some cases where we could try to rewrite a conjunct that had som Yeah, it makes sense to limit the rewrite to predicates. http://gerrit.cloudera.org:8080/#/c/16152/12/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@627 PS12, Line 627: parent instanceof BinaryPredicate || parent instanceof LikePredicate, parent); > For LIKE predicates, is there limitations in terms of wildcard usage or co On second thoughts, there's not much one can do with Like predicate involving a subquery as far as wildcard is concerned. String functions occurring on either side of the LIKE would probably work ok in the scope of this rewrite. -- To view, visit http://gerrit.cloudera.org:8080/16152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64588992901afd7cd885419a0b7f949b0b174976 Gerrit-Change-Number: 16152 Gerrit-PatchSet: 12 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 10 Jul 2020 20:36:35 +0000 Gerrit-HasComments: Yes
