Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16152 )
Change subject: IMPALA-9924: handle single subquery in or predicate ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/16152/12/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java: http://gerrit.cloudera.org:8080/#/c/16152/12/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@312 PS12, Line 312: boolean isDisjunctive = hasSubqueryInDisjunction(expr); The previous check here was too narrow - there are some cases where the disjunction is present but not at the top level of the conjunct. http://gerrit.cloudera.org:8080/#/c/16152/12/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@617 PS12, Line 617: } else if (!(parent instanceof Predicate)) { There were some cases where we could try to rewrite a conjunct that had something like a subquery as a branch of a case expression, and in that case this function can't handle that. -- To view, visit http://gerrit.cloudera.org:8080/16152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64588992901afd7cd885419a0b7f949b0b174976 Gerrit-Change-Number: 16152 Gerrit-PatchSet: 12 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 10 Jul 2020 19:29:28 +0000 Gerrit-HasComments: Yes
