Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16170 )
Change subject: IMPALA-9946: Use table id when comparing transactional state ...................................................................... Patch Set 2: Code-Review+2 (4 comments) LGTM. http://gerrit.cloudera.org:8080/#/c/16170/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16170/2//COMMIT_MSG@9 PS2, Line 9: 's nit: s http://gerrit.cloudera.org:8080/#/c/16170/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/16170/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@606 PS2, Line 606: -1 nit: -1 is used in several places for illegal table id. Is there a constant in Hive codes for this? http://gerrit.cloudera.org:8080/#/c/16170/2/fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java File fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java: http://gerrit.cloudera.org:8080/#/c/16170/2/fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java@512 PS2, Line 512: long numMisses1 = getMetricCount(testDbName, testTblName, : HdfsTable.FILEMETADATA_CACHE_MISS_METRIC); : long numHits1 = getMetricCount(testDbName, testTblName, : HdfsTable.FILEMETADATA_CACHE_HIT_METRIC); nit: not used http://gerrit.cloudera.org:8080/#/c/16170/2/fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java@526 PS2, Line 526: > nit: Are they always equal? -- To view, visit http://gerrit.cloudera.org:8080/16170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58c5bd58c4eb5663647c01ecd738b661e4e4cd74 Gerrit-Change-Number: 16170 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 13 Jul 2020 12:56:15 +0000 Gerrit-HasComments: Yes
