Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16170 )
Change subject: IMPALA-9946: Use table id when comparing transactional state ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/16170/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16170/2//COMMIT_MSG@9 PS2, Line 9: 's > nit: s Done http://gerrit.cloudera.org:8080/#/c/16170/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/16170/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@606 PS2, Line 606: -1 > nit: -1 is used in several places for illegal table id. Is there a constant Unfortunately, we don't have it. Although from code inspection from the Hive side, it looks like the table id will always be >=0 depending on the kind of backing database. I can create a private static constant in CatalogServiceCatalog.java to make it easy to track on our side. http://gerrit.cloudera.org:8080/#/c/16170/2/fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java File fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java: http://gerrit.cloudera.org:8080/#/c/16170/2/fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java@512 PS2, Line 512: long numMisses1 = getMetricCount(testDbName, testTblName, : HdfsTable.FILEMETADATA_CACHE_MISS_METRIC); : long numHits1 = getMetricCount(testDbName, testTblName, : HdfsTable.FILEMETADATA_CACHE_HIT_METRIC); > nit: not used Done -- To view, visit http://gerrit.cloudera.org:8080/16170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58c5bd58c4eb5663647c01ecd738b661e4e4cd74 Gerrit-Change-Number: 16170 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Mon, 13 Jul 2020 18:47:10 +0000 Gerrit-HasComments: Yes
