Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16179 )
Change subject: IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/16179/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16179/4//COMMIT_MSG@9 PS4, Line 9: in a : timestamps typo http://gerrit.cloudera.org:8080/#/c/16179/4//COMMIT_MSG@10 PS4, Line 10: becouse same typo http://gerrit.cloudera.org:8080/#/c/16179/4//COMMIT_MSG@10 PS4, Line 10: becouse typo http://gerrit.cloudera.org:8080/#/c/16179/4//COMMIT_MSG@12 PS4, Line 12: Updated files connected to the drop of dateless timestamps. I don't see the point of this sentence. Here we don't know what files have been changed by that other patch so this doesn't bring too much value. http://gerrit.cloudera.org:8080/#/c/16179/4/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/16179/4/be/src/exprs/expr-test.cc@3318 PS4, Line 3318: //IMPALA-9531 nit: leave a space after // http://gerrit.cloudera.org:8080/#/c/16179/4/be/src/exprs/expr-test.cc@3324 PS4, Line 3324: TestIsNull I don't understand. In Patch Set 3 this was a positive test, checking that this input results in a valid output. Then in PS4 you changed this to expect null instead without having any relevant code changes. Was it failing in PS3 or is it failing now in PS4? -- To view, visit http://gerrit.cloudera.org:8080/16179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75bd47b6627a2e338c46dc354f7e67d34c1abbcf Gerrit-Change-Number: 16179 Gerrit-PatchSet: 4 Gerrit-Owner: Adam Tamas <[email protected]> Gerrit-Reviewer: Adam Tamas <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 13 Jul 2020 19:51:26 +0000 Gerrit-HasComments: Yes
