Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16179 )
Change subject: IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix ...................................................................... Patch Set 5: (2 comments) The patch seems fine. Could you comment on the Jira for IMPALA-9531 that this (IMPALA-9941) is also required? http://gerrit.cloudera.org:8080/#/c/16179/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16179/4//COMMIT_MSG@12 PS4, Line 12: Updated some missed files connected to the drop of dateless > Done Much better, thanks! http://gerrit.cloudera.org:8080/#/c/16179/4/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/16179/4/be/src/exprs/expr-test.cc@3324 PS4, Line 3324: TestIsNull > After IMPALA-9531 both the cast and the TimestampValue::ParseSimpleDateForm Thx for the explanation! I agree it's better to be a null check. -- To view, visit http://gerrit.cloudera.org:8080/16179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75bd47b6627a2e338c46dc354f7e67d34c1abbcf Gerrit-Change-Number: 16179 Gerrit-PatchSet: 5 Gerrit-Owner: Adam Tamas <[email protected]> Gerrit-Reviewer: Adam Tamas <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 14 Jul 2020 08:53:52 +0000 Gerrit-HasComments: Yes
