Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16206 )
Change subject: IMPALA-9964: Fill file descriptors properly in setFileMetadataFromFS ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/16206/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/16206/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3150 PS4, Line 3150: loadAndSet > May be I misunderstand, why we do a loadAndSet here? The original intention If I read the code correctly loadAndSet() only differs from loadAndGet() in that it sets the partition builders' file descriptors. To actually change the cached table metadata in catalogd we'd need to build the partitions and add them explicitly to the table: https://github.com/apache/impala/blob/dabcedeca363051a9d73f2abb1a88ff230e41cc7/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java#L645 -- To view, visit http://gerrit.cloudera.org:8080/16206 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2927171cf426597c86766fb83d565c5e57025c73 Gerrit-Change-Number: 16206 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 17 Jul 2020 07:36:41 +0000 Gerrit-HasComments: Yes
