Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16206 )
Change subject: IMPALA-9964: Fill file descriptors properly in setFileMetadataFromFS ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/16206/4/fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java File fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java: http://gerrit.cloudera.org:8080/#/c/16206/4/fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java@572 PS4, Line 572: long previousVersion = tbl.getCatalogVersion(); not used http://gerrit.cloudera.org:8080/#/c/16206/4/fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java@576 PS4, Line 576: executeHiveSql("insert into " + getTestFullAcidTblName() + " select * from " : + "functional_orc_def.alltypes"); this insert is not needed -- To view, visit http://gerrit.cloudera.org:8080/16206 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2927171cf426597c86766fb83d565c5e57025c73 Gerrit-Change-Number: 16206 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 17 Jul 2020 07:43:09 +0000 Gerrit-HasComments: Yes
