Hello Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16196
to look at the new patch set (#6).
Change subject: IMPALA-9882: Import KLL functionality from Apache DataSketches
......................................................................
IMPALA-9882: Import KLL functionality from Apache DataSketches
First, I updated our existing snapshot of DataSketches to the
following commit:
c67d92faad3827932ca3b5d864222e64977f2c20
"Merge pull request #166 from gaborkaszab/const_cast"
This affects files originated from kll/ and common/ directories of
the DataSketches repo.
Then I copied all the files needed for KLL into our snapshot
directory.
You can find the original Apache DataSketches files here:
https://github.com/apache/incubator-datasketches-cpp
This new snapshot however, broke the interface we used for
serializing hll_union objects with dropping serialize_compact(). As a
solution I had to make changes to the serialization and merging
phases of the union operator by not serializing hll_union itself but
the underlying hll_sketch instead.
Change-Id: I848488d5145c808109bd50aecfbf3ef83f981943
---
M be/src/exprs/CMakeLists.txt
M be/src/exprs/aggregate-functions-ir.cc
M be/src/exprs/datasketches-test.cc
M be/src/thirdparty/datasketches/AuxHashMap-internal.hpp
D be/src/thirdparty/datasketches/CommonUtil.hpp
M be/src/thirdparty/datasketches/CompositeInterpolationXTable-internal.hpp
M be/src/thirdparty/datasketches/CompositeInterpolationXTable.hpp
M be/src/thirdparty/datasketches/CouponHashSet-internal.hpp
M be/src/thirdparty/datasketches/CouponList-internal.hpp
M be/src/thirdparty/datasketches/Hll4Array-internal.hpp
M be/src/thirdparty/datasketches/HllArray-internal.hpp
M be/src/thirdparty/datasketches/HllSketch-internal.hpp
M be/src/thirdparty/datasketches/HllSketchImplFactory.hpp
M be/src/thirdparty/datasketches/HllUnion-internal.hpp
M be/src/thirdparty/datasketches/HllUtil.hpp
M be/src/thirdparty/datasketches/MurmurHash3.h
M be/src/thirdparty/datasketches/README.md
A be/src/thirdparty/datasketches/bounds_binomial_proportions.hpp
A be/src/thirdparty/datasketches/common_defs.hpp
A be/src/thirdparty/datasketches/count_zeros.hpp
M be/src/thirdparty/datasketches/hll.hpp
A be/src/thirdparty/datasketches/kll_helper.hpp
A be/src/thirdparty/datasketches/kll_helper_impl.hpp
A be/src/thirdparty/datasketches/kll_quantile_calculator.hpp
A be/src/thirdparty/datasketches/kll_quantile_calculator_impl.hpp
A be/src/thirdparty/datasketches/kll_sketch.hpp
A be/src/thirdparty/datasketches/kll_sketch_impl.hpp
A be/src/thirdparty/datasketches/memory_operations.hpp
A be/src/thirdparty/datasketches/serde.hpp
29 files changed, 3,280 insertions(+), 347 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/16196/6
--
To view, visit http://gerrit.cloudera.org:8080/16196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I848488d5145c808109bd50aecfbf3ef83f981943
Gerrit-Change-Number: 16196
Gerrit-PatchSet: 6
Gerrit-Owner: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
