Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16196 )
Change subject: IMPALA-9882: Import KLL functionality from Apache DataSketches ...................................................................... Patch Set 8: Code-Review+2 (4 comments) Carry +2 from Csaba. http://gerrit.cloudera.org:8080/#/c/16196/6/be/src/thirdparty/datasketches/README.md File be/src/thirdparty/datasketches/README.md: http://gerrit.cloudera.org:8080/#/c/16196/6/be/src/thirdparty/datasketches/README.md@2 PS6, Line 2: s > typo Done http://gerrit.cloudera.org:8080/#/c/16196/6/be/src/thirdparty/datasketches/README.md@4 PS6, Line 4: the following folders > I would prefer to move this to a separate list, where all lines contain a d Done http://gerrit.cloudera.org:8080/#/c/16196/6/be/src/thirdparty/datasketches/README.md@6 PS6, Line 6: kll/include/ > nit: . or ... ? Done http://gerrit.cloudera.org:8080/#/c/16196/6/be/src/thirdparty/datasketches/README.md@14 PS6, Line 14: Browse the source files here: > nit: extra line(s) Done -- To view, visit http://gerrit.cloudera.org:8080/16196 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I848488d5145c808109bd50aecfbf3ef83f981943 Gerrit-Change-Number: 16196 Gerrit-PatchSet: 8 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 27 Jul 2020 07:31:18 +0000 Gerrit-HasComments: Yes
