Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16220 )
Change subject: IMPALA-9989 Improve admission control pool stats logging ...................................................................... Patch Set 16: (4 comments) http://gerrit.cloudera.org:8080/#/c/16220/16/be/src/scheduling/admission-controller-test.cc File be/src/scheduling/admission-controller-test.cc: http://gerrit.cloudera.org:8080/#/c/16220/16/be/src/scheduling/admission-controller-test.cc@1073 PS16, Line 1073: 5 * MEGABYTE /*min*/, 20 * MEGABYTE /*max*/, 100 * MEGABYTE /*total*/, 4 /*running*/)); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/16220/16/be/src/scheduling/admission-controller-test.cc@1076 PS16, Line 1076: 10 * MEGABYTE /*min*/, 200 * MEGABYTE /*max*/, 500 * MEGABYTE /*total*/, 40 /*running*/)); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/16220/16/be/src/scheduling/admission-controller-test.cc@1079 PS16, Line 1079: 10 * MEGABYTE /*min*/, 2000 * MEGABYTE /*max*/,10000 * MEGABYTE /*total*/, 100 /*running*/)); line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/16220/16/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/16220/16/be/src/scheduling/admission-controller.cc@350 PS16, Line 350: string AdmissionController::DebugTopNQueriesForAllPoolsInHost(const std::string& host_id) { line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/16220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id995a9d044082c3b8f044e1ec25bb4c64347f781 Gerrit-Change-Number: 16220 Gerrit-PatchSet: 16 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 31 Jul 2020 16:31:05 +0000 Gerrit-HasComments: Yes
