Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16220 )
Change subject: IMPALA-9989 Improve admission control pool stats logging ...................................................................... Patch Set 19: (3 comments) http://gerrit.cloudera.org:8080/#/c/16220/18/be/src/scheduling/admission-controller-test.cc File be/src/scheduling/admission-controller-test.cc: http://gerrit.cloudera.org:8080/#/c/16220/18/be/src/scheduling/admission-controller-test.cc@1073 PS18, Line 1073: 5 * MEGABYTE /*min*/, 20 * MEGABYTE /*max*/, 100 * MEGABYTE /*total*/, > line too long (97 > 90) Done http://gerrit.cloudera.org:8080/#/c/16220/18/be/src/scheduling/admission-controller-test.cc@1076 PS18, Line 1076: MakePoolStats(5000, 10, 0, MakeHeavyMemoryQueryList(HOST_1, QUEUE_C, 2), > line too long (100 > 90) Done http://gerrit.cloudera.org:8080/#/c/16220/18/be/src/scheduling/admission-controller-test.cc@1079 PS18, Line 1079: AddStatsToTopic(&membership, HOST_2, QUEUE_C, > line too long (103 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/16220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id995a9d044082c3b8f044e1ec25bb4c64347f781 Gerrit-Change-Number: 16220 Gerrit-PatchSet: 19 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 31 Jul 2020 19:31:11 +0000 Gerrit-HasComments: Yes
