Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16263 )
Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries ...................................................................... Patch Set 3: (2 comments) Looks good to me. http://gerrit.cloudera.org:8080/#/c/16263/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16263/3//COMMIT_MSG@9 PS3, Line 9: so Just wonder if some other .so files in toolchain are worth the stripping effort. [11:30:03 qchen@qifan-10229: Impala] find . -name lib*so -exec file {} \; | grep "not stripped" ./toolchain/toolchain-packages-gcc7.5.0/thrift-0.11.0-p2/lib/libthriftz-0.11.0.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, not stripped ./toolchain/toolchain-packages-gcc7.5.0/thrift-0.11.0-p2/lib/libthrift-0.11.0.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, not stripped ./toolchain/toolchain-packages-gcc7.5.0/llvm-5.0.1-asserts-p2/lib/clang/5.0.1/lib/linux/libclang_rt.asan-x86_64.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, with debug_info, not stripped ./toolchain/toolchain-packages-gcc7.5.0/llvm-5.0.1-asserts-p2/lib/clang/5.0.1/lib/linux/libclang_rt.dyndd-x86_64.so: ELF 64-bit LSB shared object, x86-64, version 1 (GNU/Linux), dynamically linked, with debug_info, not stripped ./toolchain/toolchain-packages-gcc7.5.0/llvm-5.0.1-asserts-p2/lib/clang/5.0.1/lib/linux/libclang_rt.ubsan_standalone-x86_64.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, with debug_info, not stripped ./toolchain/toolchain-packages-gcc7.5.0/llvm-5.0.1-asserts-p2/lib/clang/5.0.1/lib/linux/libclang_rt.ubsan_standalone_cxx-x86_64.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, with debug_info, not stripped ./toolchain/toolchain-packages-gcc7.5.0/llvm-5.0.1-p2/lib/clang/5.0.1/lib/linux/libclang_rt.asan-x86_64.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, with debug_info, not stripped ./toolchain/toolchain-packages-gcc7.5.0/llvm-5.0.1-p2/lib/clang/5.0.1/lib/linux/libclang_rt.dyndd-x86_64.so: ELF 64-bit LSB shared object, x86-64, version 1 (GNU/Linux), dynamically linked, with debug_info, not stripped ./toolchain/toolchain-packages-gcc7.5.0/llvm-5.0.1-p2/lib/clang/5.0.1/lib/linux/libclang_rt.ubsan_standalone-x86_64.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, with debug_info, not stripped ./toolchain/toolchain-packages-gcc7.5.0/llvm-5.0.1-p2/lib/clang/5.0.1/lib/linux/libclang_rt.ubsan_standalone_cxx-x86_64.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, with debug_info, not stripped ./toolchain/toolchain-packages-gcc7.5.0/gdb-7.9.1-p1/lib/libinproctrace.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, not stripped ./toolchain/toolchain-packages-gcc7.5.0/openssl-1.0.2l/lib/engines/libsureware.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, not stripped ./toolchain/toolchain-packages-gcc7.5.0/openssl-1.0.2l/lib/engines/libcswift.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, not stripped ./toolchain/toolchain-packages-gcc7.5.0/openssl-1.0.2l/lib/engines/lib4758cca.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, not stripped ./toolchain/toolchain-packages-gcc7.5.0/openssl-1.0.2l/lib/engines/libaep.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, not stripped ./toolchain/toolchain-packages-gcc7.5.0/openssl-1.0.2l/lib/engines/libcapi.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, not stripped ./toolchain/toolchain-packages-gcc7.5.0/openssl-1.0.2l/lib/engines/libubsec.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, not stripped ./toolchain/toolchain-packages-gcc7.5.0/openssl-1.0.2l/lib/engines/libatalla.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, not stripped ./toolchain/toolchain-packages-gcc7.5.0/openssl-1.0.2l/lib/engines/libpadlock.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, not stripped ./toolchain/toolchain-packages-gcc7.5.0/openssl-1.0.2l/lib/engines/libnuron.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, not stripped ./toolchain/toolchain-packages-gcc7.5.0/openssl-1.0.2l/lib/engines/libchil.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, not stripped ./toolchain/toolchain-packages-gcc7.5.0/openssl-1.0.2l/lib/engines/libgmp.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, not stripped ./toolchain/toolchain-packages-gcc7.5.0/openssl-1.0.2l/lib/engines/libgost.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, not stripped ./toolchain/toolchain-packages-gcc7.5.0/thrift-0.9.3-p8/lib/libthriftz-0.9.3.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, not stripped ./toolchain/toolchain-packages-gcc7.5.0/thrift-0.9.3-p8/lib/libthrift-0.9.3.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, not stripped http://gerrit.cloudera.org:8080/#/c/16263/3/docker/setup_build_context.py File docker/setup_build_context.py: http://gerrit.cloudera.org:8080/#/c/16263/3/docker/setup_build_context.py@87 PS3, Line 87: .py Do we need to spell "-gdb.py" out here? -- To view, visit http://gerrit.cloudera.org:8080/16263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I61fdf47041bd96248ecb48ae57dde143de2da294 Gerrit-Change-Number: 16263 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 04 Aug 2020 15:33:28 +0000 Gerrit-HasComments: Yes
