Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16263 )
Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/16263/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16263/3//COMMIT_MSG@9 PS3, Line 9: so > Just wonder if some other .so files in toolchain are worth the stripping ef Most of these aren't copied into the Docker images. I doubled checked and now we strip debug symbols from all .so files in the Docker images that have a non-trivial size. http://gerrit.cloudera.org:8080/#/c/16263/3/docker/setup_build_context.py File docker/setup_build_context.py: http://gerrit.cloudera.org:8080/#/c/16263/3/docker/setup_build_context.py@87 PS3, Line 87: .py > +1, if we're copying them into the container, it's a mistake Done http://gerrit.cloudera.org:8080/#/c/16263/3/docker/setup_build_context.py@91 PS3, Line 91: check_call([STRIP, "--strip-debug", libstdcpp_so, "-o", : os.path.join(LIB_DIR, os.path.basename(libstdcpp_so))]) > Nit: I think it would be good to factor out this strip call into a function Done -- To view, visit http://gerrit.cloudera.org:8080/16263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I61fdf47041bd96248ecb48ae57dde143de2da294 Gerrit-Change-Number: 16263 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 07 Aug 2020 00:05:23 +0000 Gerrit-HasComments: Yes
