Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16175 )
Change subject: IMPALA-9926 base64decode % will not return error when in newer OS ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/16175/4/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/16175/4/be/src/exprs/expr-test.cc@4808 PS4, Line 4808: TestStringValue("base64decode('YWxwaGE%')", "alpha\377"); I think this is a bug in cyrus_sasl for aarch64. Can you add a comment to that effect? Their code for this function hasn't changed in a long time, but I think the issue is that char is unsigned on aarch64 so the -1 values in this array get cast to 255 - https://github.com/cyrusimap/cyrus-sasl/blob/master/lib/saslutil.c#L97 -- To view, visit http://gerrit.cloudera.org:8080/16175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9bd9e03d5f744c18c957cdaf2064fa918086004 Gerrit-Change-Number: 16175 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <zhaoren...@hotmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 05 Aug 2020 22:11:34 +0000 Gerrit-HasComments: Yes
