Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16175 )
Change subject: IMPALA-9926: base64decode returns incorrect result on aarch64 ...................................................................... Patch Set 7: Code-Review+2 I updated the commit message just to link to the bug, I think we can move forward with this to get the test to pass. I think the two alternatives are to a) wait for all the vendors to fix cyrus-sasl. Agree they could compiled with -fsigned-char. b) implement this directly in Impala. For b), we could use an existing implementation from an Apache project as a starting point - e.g. https://github.com/apache/httpd/blob/971fc8f5b5d664ddeb5d22f8adef2137c7980fc7/modules/http2/h2_util.c#L151 We don't want to bundle cyrus-sasl with Impala because that would make us responsible for CVEs (it is a security library, so tends to be sensitive to that). I am going to go ahead and run the precommit on this to get it merged. I think we should file a follow-up JIRA to fix it. -- To view, visit http://gerrit.cloudera.org:8080/16175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9bd9e03d5f744c18c957cdaf2064fa918086004 Gerrit-Change-Number: 16175 Gerrit-PatchSet: 7 Gerrit-Owner: Anonymous Coward <zhaoren...@hotmail.com> Gerrit-Reviewer: Anonymous Coward <zhaoren...@hotmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 10 Aug 2020 18:34:40 +0000 Gerrit-HasComments: No
