Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload. ...................................................................... Patch Set 4: (2 comments) Thanks Shant for adding the remaining TPC-DS queries! I only have two very minor questions out of curiosity and do not have any other comment. http://gerrit.cloudera.org:8080/#/c/16280/4/testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-1.test File testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-1.test: http://gerrit.cloudera.org:8080/#/c/16280/4/testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-1.test@33 PS4, Line 33: select sum(sales) Is there any specific reason why we have two tests for query 23 that are almost the same? It seems the only difference is the selected column(s). In TPCDS-Q23-2, the selected columns are 1) c_last_name, 2) c_first_name, and 3) sales. http://gerrit.cloudera.org:8080/#/c/16280/4/testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-1.test File testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-1.test: http://gerrit.cloudera.org:8080/#/c/16280/4/testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-1.test@45 PS4, Line 45: where i_color = 'peach' Is there any specific reason why we have two tests for query 24 that are almost the same? It seems the only difference is this condition. In TPCDS-Q24-2, the condition is i_color = 'saddle'. -- To view, visit http://gerrit.cloudera.org:8080/16280 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad Gerrit-Change-Number: 16280 Gerrit-PatchSet: 4 Gerrit-Owner: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 07 Aug 2020 22:04:24 +0000 Gerrit-HasComments: Yes
