Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload. ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/16280/4/testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-1.test File testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-1.test: http://gerrit.cloudera.org:8080/#/c/16280/4/testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-1.test@33 PS4, Line 33: select sum(sales) > Is there any specific reason why we have two tests for query 23 that are al The TPCDS query is written as two queries in one file. We separate it out like this to make the test diffing easier. The slight difference is just how TPC-DS designed this workload. http://gerrit.cloudera.org:8080/#/c/16280/4/testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-1.test File testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-1.test: http://gerrit.cloudera.org:8080/#/c/16280/4/testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-1.test@45 PS4, Line 45: where i_color = 'peach' > Is there any specific reason why we have two tests for query 24 that are al Same as above, the TPC-DS specification has it written as two semi colon separated queries. -- To view, visit http://gerrit.cloudera.org:8080/16280 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad Gerrit-Change-Number: 16280 Gerrit-PatchSet: 4 Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 07 Aug 2020 22:25:00 +0000 Gerrit-HasComments: Yes
