Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16311 )

Change subject: IMPALA-10016: Remove unnecessary jar dependencies
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/16311/1/fe/src/main/java/org/apache/impala/service/JniFrontend.java
File fe/src/main/java/org/apache/impala/service/JniFrontend.java:

http://gerrit.cloudera.org:8080/#/c/16311/1/fe/src/main/java/org/apache/impala/service/JniFrontend.java@768
PS1, Line 768:     String domainSocketPath = 
conf.getTrimmed(HdfsClientConfigKeys.DFS_DOMAIN_SOCKET_PATH_KEY,
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/16311/1/fe/src/main/java/org/apache/impala/util/FsPermissionChecker.java
File fe/src/main/java/org/apache/impala/util/FsPermissionChecker.java:

http://gerrit.cloudera.org:8080/#/c/16311/1/fe/src/main/java/org/apache/impala/util/FsPermissionChecker.java@42
PS1, Line 42: import static 
org.apache.hadoop.hdfs.client.HdfsClientConfigKeys.DeprecatedKeys.DFS_PERMISSIONS_SUPERUSERGROUP_KEY;
line too long (115 > 90)


http://gerrit.cloudera.org:8080/#/c/16311/1/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java
File fe/src/test/java/org/apache/impala/service/JniFrontendTest.java:

http://gerrit.cloudera.org:8080/#/c/16311/1/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java@105
PS1, Line 105:         
HdfsClientConfigKeys.DFS_CLIENT_USE_LEGACY_BLOCKREADERLOCAL_DEFAULT)).thenReturn(false);
line too long (96 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/16311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadbb6142466f73f067dd7cf9d401ff81145c74cc
Gerrit-Change-Number: 16311
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Sat, 08 Aug 2020 00:05:09 +0000
Gerrit-HasComments: Yes

Reply via email to