Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16311 )
Change subject: IMPALA-10030: Remove unnecessary jar dependencies ...................................................................... Patch Set 2: (2 comments) Thanks for the cleanup! Just had a couple of comments. http://gerrit.cloudera.org:8080/#/c/16311/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16311/2//COMMIT_MSG@34 PS2, Line 34: * Ran core tests Can we test in some kind of environment with ranger just to confirm it wasn't depending incidentally on the kafka jars? http://gerrit.cloudera.org:8080/#/c/16311/2/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/16311/2/fe/pom.xml@960 PS2, Line 960: <exclusions> I think this ozone exclusion deserves a comment (what you said in the commit message was a good explanation). -- To view, visit http://gerrit.cloudera.org:8080/16311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadbb6142466f73f067dd7cf9d401ff81145c74cc Gerrit-Change-Number: 16311 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 12 Aug 2020 22:37:44 +0000 Gerrit-HasComments: Yes
