Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 )
Change subject: IMPALA-9979: part 2: partitioned top-n ...................................................................... Patch Set 15: (3 comments) This is ready for review. I still need to look at adding more tests for the eviction of the heaps, and maybe adjusting some planner tests. http://gerrit.cloudera.org:8080/#/c/16242/15/testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-analytic.test File testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-analytic.test: PS15: I should probably consider preserving the old version of this test with the analytic rank pushdown disabled. Or at least some of the queries. http://gerrit.cloudera.org:8080/#/c/16242/15/testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-analytic.test@399 PS15, Line 399: # rank() predicate operands is flipped. I should another version of this where the pushdown is now applied. http://gerrit.cloudera.org:8080/#/c/16242/15/testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-analytic.test@540 PS15, Line 540: # Rank predicate's upper bound is greater than limit. Need to double-check this plan change. -- To view, visit http://gerrit.cloudera.org:8080/16242 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic638af9495981d889a4cb7455a71e8be0eb1a8e5 Gerrit-Change-Number: 16242 Gerrit-PatchSet: 15 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 11 Aug 2020 17:20:19 +0000 Gerrit-HasComments: Yes
