Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 )
Change subject: IMPALA-9979: part 2: partitioned top-n ...................................................................... Patch Set 17: Code-Review+1 (2 comments) I don't feel as strongly about refactoring TopNNode in the be as other reviewers. This is a very thorough implementation, bravo! http://gerrit.cloudera.org:8080/#/c/16242/17/be/src/exec/topn-node.cc File be/src/exec/topn-node.cc: http://gerrit.cloudera.org:8080/#/c/16242/17/be/src/exec/topn-node.cc@541 PS17, Line 541: sort(sorted_heaps.begin(), sorted_heaps.end(), : [](const PartitionHeapMap::iterator& left, : const PartitionHeapMap::iterator& right) { : int64_t left_discarded = left->second->num_tuples_discarded(); : int64_t right_discarded = right->second->num_tuples_discarded(); : if (left_discarded != right_discarded) { : return left_discarded < right_discarded; : } : return left->second->num_tuples_added_since_eviction() < : right->second->num_tuples_added_since_eviction(); : } Nice, very nice. http://gerrit.cloudera.org:8080/#/c/16242/17/fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java File fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java: http://gerrit.cloudera.org:8080/#/c/16242/17/fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java@82 PS17, Line 82: public static String RANK = "rank"; : public static String DENSERANK = "dense_rank"; : public static String ROWNUMBER = "row_number"; nit: a bit of an eye soar, would you mind moving the public members to the begining or end of the block. -- To view, visit http://gerrit.cloudera.org:8080/16242 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic638af9495981d889a4cb7455a71e8be0eb1a8e5 Gerrit-Change-Number: 16242 Gerrit-PatchSet: 17 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 15 Sep 2020 01:57:10 +0000 Gerrit-HasComments: Yes
