Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16320 )
Change subject: IMPALA-10016: Split jars for Impala exec and coord Docker images ...................................................................... Patch Set 2: (2 comments) Did you think at all about combining the coordinator and catalog base images, since they would need basically the same jars. And they might get scheduled on the same node so could benefit significantly from sharing the base image. http://gerrit.cloudera.org:8080/#/c/16320/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16320/2//COMMIT_MSG@58 PS2, Line 58: * Ran core tests How confident are we that that precommit tests will catch missing jars from the executor? http://gerrit.cloudera.org:8080/#/c/16320/2/docker/impalad_coord_exec/Dockerfile File docker/impalad_coord_exec/Dockerfile: PS2: We could probably just make this a copy of the coordinator container since it has the same requirements. TBH we could get rid of the coord_exec container since I don't think it adds much over the coordinator. -- To view, visit http://gerrit.cloudera.org:8080/16320 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I899859a38d8ccab890de889a49ef132a89289dfd Gerrit-Change-Number: 16320 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 11 Aug 2020 19:05:09 +0000 Gerrit-HasComments: Yes
