Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16320 )
Change subject: IMPALA-10016: Split jars for Impala exec and coord Docker images ...................................................................... Patch Set 4: > (1 comment) > > The code changes basically look good. Let me know how testing goes, > I can approve it then. Is there a change that we could make to the dockerized tests that would help us test the coordinator-only and executor-only images? At the moment, the dockerized tests use the impalad_coord_exec docker image, and that has been fine for coverage because impalad_coord_exec, impalad_executor, and impalad_coordinator have been so similar. I wonder how much work it would be to migrate to using one impalad_coordinator and three impalad_executor nodes (or one impalad_coord_exec and two impalad_executor nodes). Would this be a useful direction? -- To view, visit http://gerrit.cloudera.org:8080/16320 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I899859a38d8ccab890de889a49ef132a89289dfd Gerrit-Change-Number: 16320 Gerrit-PatchSet: 4 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 31 Aug 2020 20:10:13 +0000 Gerrit-HasComments: No
